Skip to content

Use fixed seed in test#1957

Merged
victorlin merged 1 commit intomasterfrom
victorlin/test-seed
Feb 5, 2026
Merged

Use fixed seed in test#1957
victorlin merged 1 commit intomasterfrom
victorlin/test-seed

Conversation

@victorlin
Copy link
Member

@victorlin victorlin commented Feb 4, 2026 •
edited
Loading

This prevents test failures due to sampling differences.

Example of such a failure:

tests/test_ancestral.py:93: in test_vcf_with_ambiguity_inferred
    assert(gather_mutations_at_pos(3, nuc_result)==[])
E   AssertionError: assert ['C3A', 'C3A'] == []
E     
E     Left contains 2 more items, first extra item: 'C3A'
E     
E     Full diff:
E     - []
E     + [
E     +     'C3A',
E     +     'C3A',
E     + ]

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@victorlin
Use fixed seed in test
bfb3083 
This prevents test failures due to sampling differences.
@victorlin victorlin self-assigned this Feb 4, 2026
joverlee521
joverlee521 approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, totally missed this error was due to sampling differences 🙏

@victorlin victorlin merged commit b4f4657 into master Feb 5, 2026
32 checks passed
@victorlin victorlin deleted the victorlin/test-seed branch February 5, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

Assignees

@victorlin victorlin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@victorlin @joverlee521